Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lobby Song: Shibamata #904

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Conversation

McBosserson
Copy link
Contributor

About the PR

Adds Shibamata from the Nyanotrasen fork to the list of songs played in the lobby.
The info in attributions may be flawed but is as accurate as I can get.

Media

  • This PR does not require an ingame showcase

Changelog

🆑

  • add: Shibamata as lobby song

@McBosserson
Copy link
Contributor Author

Everything should be in order this time. I deleted my fork to reset it, as I haven't a clue what I did.
Some people want this, others find it annoying. I think it is a fitting song for this game, but maybe not Frontier.

@dvir001
Copy link
Contributor

dvir001 commented Jan 23, 2024

Everything should be in order this time. I deleted my fork to reset it, as I haven't a clue what I did. Some people want this, others find it annoying. I think it is a fitting song for this game, but maybe not Frontier.

Worst case we add it, get feedback and see if we keep it.

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jan 24, 2024
@dvir001 dvir001 self-requested a review January 24, 2024 19:06
@dvir001 dvir001 merged commit 3cf2617 into new-frontiers-14:master Jan 24, 2024
10 of 11 checks passed
FrontierATC added a commit that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants